zuul/nodepool
Code Issues Proposed changes

Fix gce test pausing at quote

Browse Source 
The existing test for gce machine boots assumed that after the first
boot was complete it would be at quote causing the second request to
pause. Unfortunately, we had quota for more than one instance which
meant that the test proceeded with fulfilling the second request. If
that was request was fulfilled quickly enough we would fail because the
status would change from PENDING to FULFILLED.

Fix this by updating our cloud quota to allow for a single instance
instead which will cause the pause to happen.

Change-Id: I4ebeb684a2c99ad1af12420f4d882777c38fb156
This commit is contained in:
Clark Boylan 2022-10-21 15:30:22 -07:00 committed by Clark Boylan
parent 2a231a08c9
commit 9fcf9d05ff
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
nodepool/tests/unit/test_driver_gce.py
View File

@ -174,7 +174,9 @@ class GCloudRegions(GCloudCollection):
{"metric": "IN_USE_ADDRESSES", "limit": 8, "usage": 0}, # noqa
{"metric": "SSD_TOTAL_GB", "limit": 500, "usage": 0}, # noqa
{"metric": "LOCAL_SSD_TOTAL_GB", "limit": 6000, "usage": 0}, # noqa
{"metric": "INSTANCES", "limit": 24, "usage": 0}, # noqa
# Set to 1 to force test_gce_machine to pause for quota
# between instance boots.
{"metric": "INSTANCES", "limit": 1, "usage": 0}, # noqa
{"metric": "PREEMPTIBLE_CPUS", "limit": 0, "usage": 0}, # noqa
{"metric": "COMMITTED_CPUS", "limit": 0, "usage": 0}, # noqa
{"metric": "INTERNAL_ADDRESSES", "limit": 200, "usage": 0}, # noqa