From d6b13dd47f034e5b28aac5d58a77b60761e8e5f8 Mon Sep 17 00:00:00 2001
From: "James E. Blair" <jim@acmegating.com>
Date: Thu, 28 Mar 2024 09:19:15 -0700
Subject: [PATCH] Fix inheritance of delete-after-upload option

This diskimage option was not correctly inherited when using
a parent diskimage.

Change-Id: If48c218a0b8b9432e54a55bd947b04016db78479
---
 nodepool/config.py                                          | 4 +++-
 nodepool/tests/fixtures/node_diskimage_cleanup_formats.yaml | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/nodepool/config.py b/nodepool/config.py
index b0e0f0be9..d27472804 100644
--- a/nodepool/config.py
+++ b/nodepool/config.py
@@ -348,7 +348,9 @@ class DiskImage(ConfigValue):
         keep_image_types = config.get('keep-formats', None)
         if keep_image_types:
             self.keep_image_types = set(keep_image_types)
-        self.delete_after_upload = config.get('delete-after-upload', False)
+        delete_after_upload = config.get('delete-after-upload', None)
+        if delete_after_upload is not None:
+            self.delete_after_upload = delete_after_upload
         pause = config.get('pause', None)
         if pause:
             self.pause = pause
diff --git a/nodepool/tests/fixtures/node_diskimage_cleanup_formats.yaml b/nodepool/tests/fixtures/node_diskimage_cleanup_formats.yaml
index f266774af..eb251bcec 100644
--- a/nodepool/tests/fixtures/node_diskimage_cleanup_formats.yaml
+++ b/nodepool/tests/fixtures/node_diskimage_cleanup_formats.yaml
@@ -61,10 +61,12 @@ providers:
             min-ram: 8192
 
 diskimages:
-  - name: fake-image
+  - name: parent
     delete-after-upload: true
     keep-formats:
       - qcow2
+  - name: fake-image
+    parent: parent
     elements:
       - fedora
       - vm