From 1280a99434e973f907c936a6e538c6fe7c6bb27f Mon Sep 17 00:00:00 2001 From: Paul Belanger Date: Tue, 18 Jul 2017 17:01:55 -0400 Subject: [PATCH] Create tox-pep8 jobs Because we want to use tox role variables (tox_envlist) across multiple plays. We need to setup the variable in zuul.yaml. However, this now means we need to create tox-pep8 job now since we are using the tox/run playbook. Change-Id: I6c15c076a510375dfacc66a0e07bc3f1228adf06 Signed-off-by: Paul Belanger --- playbooks/tox/linters.yaml | 20 -------------------- zuul.yaml | 13 ++++++++++++- 2 files changed, 12 insertions(+), 21 deletions(-) delete mode 100644 playbooks/tox/linters.yaml diff --git a/playbooks/tox/linters.yaml b/playbooks/tox/linters.yaml deleted file mode 100644 index 2ff4661fb..000000000 --- a/playbooks/tox/linters.yaml +++ /dev/null @@ -1,20 +0,0 @@ -- hosts: all - pre_tasks: - - name: Register tox environment list - command: tox -l - args: - chdir: "src/{{ zuul.project.canonical_name }}" - register: envlist - - - name: Define tox_envlist fact for pep8 - set_fact: - tox_envlist: 'pep8' - when: envlist.stdout.find('pep8') != -1 - - - name: Define tox_envlist fact for linters - set_fact: - tox_envlist: 'linters' - when: envlist.stdout.find('linters') != -1 - - roles: - - tox diff --git a/zuul.yaml b/zuul.yaml index 12c0c5409..3a292db64 100644 --- a/zuul.yaml +++ b/zuul.yaml @@ -85,7 +85,18 @@ Runs code linting tests. Uses tox with the "linters" environment. - run: playbooks/tox/linters + vars: + tox_envlist: linters + +- job: + name: tox-pep8 + parent: tox + description: | + Runs code pep8 tests. + + Uses tox with the "pep8" environment. + vars: + tox_envlist: pep8 - job: name: tox-cover