Use --password-stdin for upload-container-image

This allows us to drop the no_log field, and expose more info to the
user.

Change-Id: Ib5de193ec285d2a9715d01ca3c7a39da741f03d3
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

roles/upload-container-image/tasks/push.yaml

@@ -1,6 +1,22 @@
+- name: Create tempfile for password
+  tempfile:
+    state: file
+  register: _password_tmp
+
+- name: Populate tempfile
+  copy:
+    content: "{{ container_registry_credentials[zj_image.registry].password }}"
+    dest: "{{ _password_tmp.path }}"
+    mode: 0600
+
 - name: Log in to registry
-  command: "{{ container_command }} login -u {{ container_registry_credentials[zj_image.registry].username }} -p {{ container_registry_credentials[zj_image.registry].password }} {{ zj_image.registry }}"
+  block:
-  no_log: true
+    - name: Log in to registry
+      shell: "cat {{ _password_tmp.path }} | {{ container_command }} login -u {{ container_registry_credentials[zj_image.registry].username }} --password-stdin {{ zj_image.registry }}"
+
+  always:
+    - name: Remove password from disk
+      command: "shred {{ _password_tmp.path }}"
 
 - name: Publish images
   block: