zuul/zuul-jobs
Code Issues Proposed changes

Disable E208 for now

Browse Source 
ansible-lint throws an undocumented error "E208 File permissions not
mentioned" that looks too aggressive, for example it complains IMHO
wrongly about:

roles/add-build-sshkey/tasks/remote-linux.yaml:1: [E208] File permissions not mentioned
roles/add-build-sshkey/tasks/remote-linux.yaml:14: [E208] File permissions not mentioned
roles/add-build-sshkey/tasks/remote-linux.yaml:20: [E208] File permissions not mentioned
roles/add-build-sshkey/tasks/remote-linux.yaml:27: [E208] File permissions not mentioned

Disable it for now until ansible-lint is fixed - and the real problems
in zuul-jobs are fixed.

https://github.com/ansible/ansible-lint/pull/949 fixes the false
positives. Once that is merged and a new release is out, we should
revert and fix the real problems.

Change-Id: I3e3978bbc9458ad79623d22969344fb46f5fee43
This commit is contained in:
Andreas Jaeger 2020-08-14 09:49:47 +02:00
parent 00f4aab4d9
commit 495c5ed62e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.ansible-lint
View File

@ -5,6 +5,10 @@ quiet: false
skip_list:
- '106' # Role name does not match ``^[a-z][a-z0-9_]+$`` pattern
- '204' # Lines should be no longer than 160 chars
# TODO(AJaeger): E208 gives false positives currently, we
# should enable it once all issues in zuul-jobs and
# ansible-lint are fixed.
- '208' # File permissions not mentioned
- '301' # Commands should not change things if nothing needs doing
rulesdir:
- ./.rules/