zuul/zuul-jobs
Code Issues Proposed changes

Remove command.warn usage

Browse Source 
This is no longer present in Ansible 9.

Removing these upsets ansible-lint, so those errors are ignored.

The base roles job has bitrotted on centos-7 and bionic due to
a bad voluptuous release used in an stestr test.  That is fixed in
this change as well.

Change-Id: I67886d5ad82ab590979f82bd102d6f974b9d4421
This commit is contained in:
James E. Blair 2024-02-09 11:25:20 -08:00
parent 9519fafd10
commit 509880073e
13 changed files with 2 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/configure-mirrors/handlers/main.yaml
View File

@ -10,8 +10,6 @@
- name: Update yum/dnf cache
become: yes
command: "{{ zj_command }}"
args:
warn: false
with_items:
- "{{ ansible_pkg_mgr }} clean all"
# verbose is needed in order to make it possible to debug potential failures

2
roles/ensure-docker/tasks/main.yaml
View File

@ -73,8 +73,6 @@
- name: Validate ability to talk with docker
command: docker ps
changed_when: false
args:
warn: no
- name: Get version details
command: docker version

2
roles/fetch-sphinx-tarball/tasks/html.yaml
View File

@ -6,8 +6,6 @@
- name: Archive HTML
command: "tar -f {{ html_archive.path }} -C {{ zuul_work_dir }}/{{ sphinx_build_dir }}/html --exclude=.doctrees -cz ."
args:
warn: false
- name: Fetch HTML
when: not zuul_use_fetch_output

1
test-playbooks/base-roles/fetch-subunit-output.yaml
View File

@ -19,6 +19,7 @@
name:
- stestr
- python-subunit
- 'voluptuous==0.13.1'
virtualenv: "{{ zuul_work_dir }}/.tox/utests/"
virtualenv_command: '{{ ensure_pip_virtualenv_command }}'

1
test-playbooks/dhall/test-dhall-diff.yaml
View File

@ -18,7 +18,6 @@
command: git commit -a -m "test update"
args:
chdir: "{{ zuul.project.src_dir }}"
warn: false
- name: Failed dhall-diff
include_role:

2
test-playbooks/dstat-graph.yaml
View File

@ -11,8 +11,6 @@
# Not using ansible pause module on purpose in order to simulate the load
- name: Simulate workload
command: sleep 10
args:
warn: false
- hosts: all
roles:

2
test-playbooks/haskell/setup-stack-project.yaml
View File

@ -5,5 +5,3 @@
- name: Copy file over zuul-jobs
command: rsync -a new-project/ "{{ zuul.project.src_dir }}/"
args:
warn: false

2
test-playbooks/javascripts/fetch-javascript-tarball.yaml
View File

@ -4,8 +4,6 @@
shell: |
mkdir -p {{ zuul.project.src_dir }}
tar czf {{ zuul.project.src_dir }}/dist.tgz /etc/os-release
args:
warn: false
tasks:
- name: Run fetch-javascript-tarball
import_role:

2
test-playbooks/python/fetch-sphinx-output.yaml
View File

@ -9,8 +9,6 @@
shell: |
mkdir -p {{ zuul.project.src_dir }}/doc/build/html
echo "<body>Hello</body>" > {{ zuul.project.src_dir }}/doc/build/html/index.html
args:
warn: false
tasks:
- name: Run fetch-sphinx-output

2
test-playbooks/python/fetch-sphinx-tarball.yaml
View File

@ -14,8 +14,6 @@
mkdir -p {{ zuul.project.src_dir }}/doc/build/html
echo "%PDF-1.2" > {{ zuul.project.src_dir }}/doc/build/pdf/doc-{{ zuul.project.short_name }}.pdf
echo "<body>Hello</body>" > {{ zuul.project.src_dir }}/doc/build/html/index.html
args:
warn: false
tasks:
# This tars up the fake sphinx output we created above on the test

2
test-playbooks/registry/test-registry.yaml
View File

@ -134,8 +134,6 @@
mkdir -p src/openstack.org/project/fake-sibling &&
touch src/opendev.org/project/fake-sibling/file &&
touch src/openstack.org/project/fake-sibling/file
args:
warn: false
- name: Build docker image
include_role:

2
test-playbooks/upload-git-mirror.yaml
View File

@ -38,7 +38,6 @@
changed_when: false
args:
chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
warn: false
register: current_commit
- name: Clone upstream zuul-jobs as a bare repository
@ -71,7 +70,6 @@
changed_when: false
args:
chdir: "{{ test_repo_path }}"
warn: false
register: after_mirror
- name: Assert that the git repositories have the same commit for HEAD

2
tox.ini
View File

@ -55,7 +55,7 @@ commands =
flake8 {posargs}
yamllint -s -f parsable .
python -m ansiblelint --version
python -m ansiblelint {env:ANSIBLELINT_OPTS:}
python -m ansiblelint {env:ANSIBLELINT_OPTS:-x command-instead-of-module,deprecated-command-syntax,no-handler}
# Ansible Syntax Check
{toxinidir}/tools/check_jobs_documented.py
{toxinidir}/tools/update-test-platforms.py