From 53c787fd47c4e948750cf702fb637ebaf4c4d012 Mon Sep 17 00:00:00 2001
From: Mohammed Naser <mnaser@vexxhost.com>
Date: Wed, 1 Apr 2020 12:55:40 -0400
Subject: [PATCH] go-jobs: improve testing

The jobs currently are not running tests if we make changes to the
"go" role due to a typo in the files.  Also, the file name should
really be go-jobs.yaml because we're testing the jobs, not any specific
role.

This patch also adds support for verifying that it works across all
of the platforms.

Change-Id: Ie6c64936d01e368f8af789f6576f8425cfd9350c
---
 zuul-tests.d/go-jobs.yaml       | 131 ++++++++++++++++++++++++++++++++
 zuul-tests.d/go-roles-jobs.yaml |  23 ------
 2 files changed, 131 insertions(+), 23 deletions(-)
 create mode 100644 zuul-tests.d/go-jobs.yaml
 delete mode 100644 zuul-tests.d/go-roles-jobs.yaml

diff --git a/zuul-tests.d/go-jobs.yaml b/zuul-tests.d/go-jobs.yaml
new file mode 100644
index 000000000..fc7974c33
--- /dev/null
+++ b/zuul-tests.d/go-jobs.yaml
@@ -0,0 +1,131 @@
+- job:
+    name: zuul-jobs-test-golang-go
+    parent: golang-go
+    description: Test the golang-go job
+    tags: all-platforms
+    files:
+      - playbooks/go
+      - roles/install-go
+      - roles/go
+      - zuul.d/go-jobs.yaml
+    vars:
+      go_command: version
+
+# -* AUTOGENERATED *-
+#  The following project section is autogenerated by
+#    tox -e update-test-platforms
+#  Please re-run to generate new job lists
+
+- job:
+    name: zuul-jobs-test-golang-go-centos-7
+    description: Test the golang-go job on centos-7
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: centos-7
+          label: centos-7
+
+- job:
+    name: zuul-jobs-test-golang-go-centos-8
+    description: Test the golang-go job on centos-8
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: centos-8
+          label: centos-8
+
+- job:
+    name: zuul-jobs-test-golang-go-debian-stretch
+    description: Test the golang-go job on debian-stretch
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: debian-stretch
+          label: debian-stretch
+
+- job:
+    name: zuul-jobs-test-golang-go-fedora-30
+    description: Test the golang-go job on fedora-30
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: fedora-30
+          label: fedora-30
+
+- job:
+    name: zuul-jobs-test-golang-go-gentoo-17-0-systemd
+    description: Test the golang-go job on gentoo-17-0-systemd
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: gentoo-17-0-systemd
+          label: gentoo-17-0-systemd
+
+- job:
+    name: zuul-jobs-test-golang-go-opensuse-15
+    description: Test the golang-go job on opensuse-15
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: opensuse-15
+          label: opensuse-15
+
+- job:
+    name: zuul-jobs-test-golang-go-opensuse-tumbleweed-nv
+    voting: false
+    description: Test the golang-go job on opensuse-tumbleweed
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: opensuse-tumbleweed
+          label: opensuse-tumbleweed
+
+- job:
+    name: zuul-jobs-test-golang-go-ubuntu-bionic
+    description: Test the golang-go job on ubuntu-bionic
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: ubuntu-bionic
+          label: ubuntu-bionic
+
+- job:
+    name: zuul-jobs-test-golang-go-ubuntu-xenial
+    description: Test the golang-go job on ubuntu-xenial
+    parent: zuul-jobs-test-golang-go
+    tags: auto-generated
+    nodeset:
+      nodes:
+        - name: ubuntu-xenial
+          label: ubuntu-xenial
+
+- project:
+    check:
+      jobs:
+        - zuul-jobs-test-golang-go-centos-7
+        - zuul-jobs-test-golang-go-centos-8
+        - zuul-jobs-test-golang-go-debian-stretch
+        - zuul-jobs-test-golang-go-fedora-30
+        - zuul-jobs-test-golang-go-gentoo-17-0-systemd
+        - zuul-jobs-test-golang-go-opensuse-15
+        - zuul-jobs-test-golang-go-opensuse-tumbleweed-nv
+        - zuul-jobs-test-golang-go-ubuntu-bionic
+        - zuul-jobs-test-golang-go-ubuntu-xenial
+    gate:
+      jobs:
+        - zuul-jobs-test-golang-go-centos-7
+        - zuul-jobs-test-golang-go-centos-8
+        - zuul-jobs-test-golang-go-debian-stretch
+        - zuul-jobs-test-golang-go-fedora-30
+        - zuul-jobs-test-golang-go-gentoo-17-0-systemd
+        - zuul-jobs-test-golang-go-opensuse-15
+        - zuul-jobs-test-golang-go-ubuntu-bionic
+        - zuul-jobs-test-golang-go-ubuntu-xenial
diff --git a/zuul-tests.d/go-roles-jobs.yaml b/zuul-tests.d/go-roles-jobs.yaml
deleted file mode 100644
index ce319b51c..000000000
--- a/zuul-tests.d/go-roles-jobs.yaml
+++ /dev/null
@@ -1,23 +0,0 @@
-- job:
-    name: zuul-jobs-test-golang-go
-    parent: golang-go
-    description: Test the golang-go job
-    files:
-      - playbooks/go
-      - roles/install-go
-      - role/go
-      - zuul.d/go-jobs.yaml
-    vars:
-      go_command: version
-
-# -* AUTOGENERATED *-
-#  The following project section is autogenerated by
-#    tox -e update-test-platforms
-#  Please re-run to generate new job lists
-
-- project:
-    check:
-      jobs: &id001
-        - zuul-jobs-test-golang-go
-    gate:
-      jobs: *id001