Bits to keep ansible-lint happy

- moved vars file under vars to avoid failure to load file (newer
  version raise error if you try to put vars outside vars/defaults as
  it will assume they are broken playbooks.
- added missing file-modes on few tasks

Change-Id: I7217469d089b655ee16cd038391cffa4197c8c83
Part-Of: https://review.opendev.org/c/zuul/zuul-jobs/+/773245

playbooks/tox/pre-molecule.yaml

@@ -9,12 +9,12 @@
       with_first_found:
         - skip: true
           files:
-            - "molecule-vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yaml"
-            - "molecule-vars/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yaml"
-            - "molecule-vars/{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yaml"
-            - "molecule-vars/{{ ansible_distribution | lower }}.yaml"
-            - "molecule-vars/{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yaml"
-            - "molecule-vars/{{ ansible_os_family | lower }}.yaml"
+            - "vars/molecule/{{ ansible_distribution | lower }}-{{ ansible_distribution_version | lower }}.yaml"
+            - "vars/molecule/{{ ansible_distribution | lower }}-{{ ansible_distribution_major_version | lower }}.yaml"
+            - "vars/molecule/{{ ansible_os_family | lower }}-{{ ansible_distribution_major_version | lower }}.yaml"
+            - "vars/molecule/{{ ansible_distribution | lower }}.yaml"
+            - "vars/molecule/{{ ansible_os_family | lower }}-{{ ansible_distribution_version.split('.')[0] }}.yaml"
+            - "vars/molecule/{{ ansible_os_family | lower }}.yaml"
       tags:
         - always
 

roles/ensure-openshift/tasks/main.yaml

@@ -22,6 +22,7 @@
       gpgcheck=1
       gpgkey=file:///etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-PaaS
     dest: /etc/yum.repos.d/origin-pass.repo
+    mode: 0644
 
 # https://www.centos.org/keys/RPM-GPG-KEY-CentOS-SIG-PaaS
 - name: "Install RPM-GPG-KEY-CentOS-SIG-PaaS"
@@ -49,6 +50,7 @@
       =CVSF
       -----END PGP PUBLIC KEY BLOCK-----
     dest: /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-PaaS
+    mode: 0644
 
 - name: Install requirements
   yum:

roles/ensure-zookeeper/tasks/setup_tls.yaml

@@ -8,6 +8,7 @@
     path: "{{ zookeeper_ca_dir }}"
     state: directory
     owner: "{{ ansible_user }}"
+    mode: 0755
   become: true
 
 - name: Copy zk-ca script