From 622baa65bfa02a592024a867c5bd94a8a4567339 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Wed, 16 Nov 2022 09:11:12 -0800 Subject: [PATCH] Add no_log to all log upload tasks Some log upload tasks were missing no_log instructions and might write out credentials to the job-output.json file. Update these tasks to include no_log. Change-Id: I1f18cec117d9205945644ce19d5584f5d676e8d8 --- roles/upload-logs-gcs/tasks/main.yaml | 1 + roles/upload-logs-s3/tasks/main.yaml | 1 + roles/upload-logs-swift/tasks/main.yaml | 1 + 3 files changed, 3 insertions(+) diff --git a/roles/upload-logs-gcs/tasks/main.yaml b/roles/upload-logs-gcs/tasks/main.yaml index 996b03034..11080ae07 100644 --- a/roles/upload-logs-gcs/tasks/main.yaml +++ b/roles/upload-logs-gcs/tasks/main.yaml @@ -19,6 +19,7 @@ - name: Upload logs to Google Cloud Storage delegate_to: localhost + no_log: true zuul_google_storage_upload: partition: "{{ zuul_log_partition }}" container: "{{ zuul_log_container }}" diff --git a/roles/upload-logs-s3/tasks/main.yaml b/roles/upload-logs-s3/tasks/main.yaml index a6ed7dcb8..ed7afc9ec 100644 --- a/roles/upload-logs-s3/tasks/main.yaml +++ b/roles/upload-logs-s3/tasks/main.yaml @@ -23,6 +23,7 @@ - name: Upload logs to S3 delegate_to: "{{ _undocumented_test_worker_node_ | default('localhost') }}" + no_log: true zuul_s3_upload: endpoint: "{{ upload_logs_s3_endpoint | default(omit) }}" partition: "{{ zuul_log_partition }}" diff --git a/roles/upload-logs-swift/tasks/main.yaml b/roles/upload-logs-swift/tasks/main.yaml index 858279880..18cb922a3 100644 --- a/roles/upload-logs-swift/tasks/main.yaml +++ b/roles/upload-logs-swift/tasks/main.yaml @@ -19,6 +19,7 @@ - name: Upload logs to swift delegate_to: localhost + no_log: true zuul_swift_upload: cloud: "{{ zuul_log_cloud_config }}" partition: "{{ zuul_log_partition }}"