Run ansible-lint on repo

This change follows  I16186c929e7d0e6e34b35271559e555255a52b00 to run
openstack-zuul-jobs-linters on the repository.

Also, silence remaining lint role.

Depends-On: I46c53229f878fc707bab627654d820b891d9f625
Change-Id: I76abf21ea51c5f7553639475e408e06768fb1016

roles/fetch-javascript-tarball/tasks/main.yaml

@@ -5,6 +5,9 @@
     cp *.tgz dist/{{ zuul.project.short_name }}-latest.tar.gz
   args:
     chdir: "{{ zuul_work_dir }}"
+  tags:
+    # Ignore ANSIBLE0007: No need to use file module instead of mkdir
+    - skip_ansible_lint
 
 - name: Ensure artifacts directory exists
   file:

test-requirements.txt

@@ -9,5 +9,3 @@ ansible<2.4
 ansible-lint
 bashate>=0.2
 zuul-sphinx>=0.1.1
-# Zuul is required to supply the zuul ansible modules for ansible-lint
--e git://git.openstack.org/openstack-infra/zuul@feature/zuulv3#egg=zuul

tox.ini

@@ -22,12 +22,19 @@ commands = bindep test
 commands = python setup.py build_sphinx
 
 [testenv:linters]
-setenv =
+passenv =
-  ANSIBLE_CONFIG = {toxinidir}/tests/ansible.cfg
+  # NOTE(pabelanger): if you'd like to run tox -elinters locally, you'll need
-  ANSIBLE_LIBRARY= {envdir}/src/zuul/zuul/ansible/library
+  # to export ANSIBLE_ROLES_PATH pointing to the currect repos.
+  # see infra-zuul-jobs-linters job for more information.
+  ANSIBLE_ROLES_PATH
 whitelist_externals = bash
 commands =
   flake8 {posargs}
+  # Ansible lint
+  # [ANSIBLE0012] Commands should not change things if nothing needs doing
+  bash -c "find playbooks -type d -name "legacy" -prune -o \
+    -type f -regex '.*.y[a]ml' -print0 | xargs -t -n1 -0 \
+    ansible-lint -xANSIBLE0012"
   # Ansible Syntax Check
   bash -c "find playbooks -type f -regex '.*.y[a]?ml' -print0 | xargs -n1 -0 \
     ansible-playbook --syntax-check -i tests/inventory 1>/dev/null"