zuul/zuul-jobs
Code Issues Proposed changes

Merge "Fix ansible-lint job"

Browse Source
This commit is contained in:
Zuul 2018-03-29 13:52:58 +00:00 committed by Gerrit Code Review
commit 819cc19d3f
5 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
roles/prepare-workspace/tasks/main.yaml
View File

@ -1,6 +1,9 @@
# TODO(pabelanger): Handle cleanup on static nodes # TODO(pabelanger): Handle cleanup on static nodes
- name: Start zuul_console daemon. - name: Start zuul_console daemon.
zuul_console: zuul_console:
tags:
# Avoid "no action detected in task" linter error
- skip_ansible_lint
- name: Synchronize src repos to workspace directory. - name: Synchronize src repos to workspace directory.
synchronize: synchronize:

4
roles/stage-output/tasks/main.yaml
View File

@ -90,6 +90,8 @@
shell: "mv {{ item.path }} {{ item.path | regex_replace(extensions_regex, '\\1_\\2.txt') }}" shell: "mv {{ item.path }} {{ item.path | regex_replace(extensions_regex, '\\1_\\2.txt') }}"
with_items: "{{ log_files_to_rename.files }}" with_items: "{{ log_files_to_rename.files }}"
chdir: "{{ stage_dir }}/logs" chdir: "{{ stage_dir }}/logs"
tags:
- skip_ansible_lint
# NOTE(andreaf) The ansible module does not support recursive archive, so # NOTE(andreaf) The ansible module does not support recursive archive, so
# using gzip is the only option here. The good bit is that gzip itself is # using gzip is the only option here. The good bit is that gzip itself is
@ -104,3 +106,5 @@
when: when:
- stage_compress_logs - stage_compress_logs
- item.type == 'logs' - item.type == 'logs'
tags:
- skip_ansible_lint

3
roles/start-zuul-console/tasks/main.yaml
View File

@ -1,3 +1,6 @@
# TODO(pabelanger): Handle cleanup on static nodes # TODO(pabelanger): Handle cleanup on static nodes
- name: Start zuul_console daemon. - name: Start zuul_console daemon.
zuul_console: zuul_console:
tags:
# Avoid "no action detected in task" linter error
- skip_ansible_lint

3
roles/upload-logs/tasks/main.yaml
View File

@ -56,3 +56,6 @@
zuul: zuul:
log_url: "{{ zuul_log_url }}/{{ zuul_log_path }}/" log_url: "{{ zuul_log_url }}/{{ zuul_log_path }}/"
when: zuul_log_url is defined when: zuul_log_url is defined
tags:
# Avoid "no action detected in task" linter error
- skip_ansible_lint

4
tox.ini
View File

@ -25,7 +25,7 @@ commands = python setup.py build_sphinx
passenv = passenv =
# NOTE(pabelanger): if you'd like to run tox -elinters locally, you'll need # NOTE(pabelanger): if you'd like to run tox -elinters locally, you'll need
# to export ANSIBLE_ROLES_PATH pointing to the currect repos. # to export ANSIBLE_ROLES_PATH pointing to the currect repos.
# see infra-zuul-jobs-linters job for more information. # see openstack-zuul-jobs-linters job for more information.
ANSIBLE_ROLES_PATH ANSIBLE_ROLES_PATH
whitelist_externals = bash whitelist_externals = bash
commands = commands =
@ -34,6 +34,8 @@ commands =
# [ANSIBLE0012] Commands should not change things if nothing needs doing # [ANSIBLE0012] Commands should not change things if nothing needs doing
bash -c "find playbooks -type f -regex '.*.ya?ml' -print0 | \ bash -c "find playbooks -type f -regex '.*.ya?ml' -print0 | \
xargs -t -n1 -0 ansible-lint -xANSIBLE0012" xargs -t -n1 -0 ansible-lint -xANSIBLE0012"
bash -c 'find roles -maxdepth 1 -mindepth 1 -type d -printf "%p/\n" | \
xargs -t -n1 ansible-lint -xANSIBLE0012'
# Ansible Syntax Check # Ansible Syntax Check
bash -c "find playbooks -type f -regex '.*.ya?ml' -exec \ bash -c "find playbooks -type f -regex '.*.ya?ml' -exec \
ansible-playbook --syntax-check -i {toxinidir}/tests/inventory \{\} + > /dev/null" ansible-playbook --syntax-check -i {toxinidir}/tests/inventory \{\} + > /dev/null"