zuul/zuul-jobs
Code Issues Proposed changes

Update tox/test-requirements

Browse Source 
In working on a different patch it became clear that flake8 wasn't
actually running such that it found errors. Updated the
test-requirements to match what's in zuul and all started working (and
failing) properly.

Change-Id: Icfdb1fedbd92ff49484b116a0879686581274a25
This commit is contained in:
Monty Taylor 2017-09-02 14:15:24 -05:00
parent 88cd3b6c58
commit 82af975879
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
3 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
roles/upload-afs/library/zuul_afs.py
View File

@ -14,11 +14,15 @@
# #
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this software. If not, see <http://www.gnu.org/licenses/>. # along with this software. If not, see <http://www.gnu.org/licenses/>.
from __future__ import absolute_import, division, print_function
__metaclass__ = type
import os import os
import subprocess import subprocess
import tempfile import tempfile
from ansible.module_utils.basic import AnsibleModule
def afs_sync(afssource, afstarget): def afs_sync(afssource, afstarget):
# Find the list of root markers in the just-completed build # Find the list of root markers in the just-completed build
@ -106,7 +110,6 @@ def main():
output = afs_sync(p['source'], p['target']) output = afs_sync(p['source'], p['target'])
module.exit_json(changed=True, build_roots=output) module.exit_json(changed=True, build_roots=output)
from ansible.module_utils.basic import * # noqa
if __name__ == '__main__': if __name__ == '__main__':
main() main()

5
test-requirements.txt
View File

@ -1,8 +1,9 @@
# The order of packages is significant, because pip processes them in the order # The order of packages is significant, because pip processes them in the order
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
pbr>=1.1.0 pep8
hacking>=0.12.0,<0.13 # Apache-2.0 pyflakes
flake8
ansible-lint ansible-lint
bashate>=0.2 bashate>=0.2

3
tox.ini
View File

@ -43,6 +43,7 @@ commands = {posargs}
[flake8] [flake8]
# These are ignored intentionally in openstack-infra projects; # These are ignored intentionally in openstack-infra projects;
# please don't submit patches that solely correct them or enable them. # please don't submit patches that solely correct them or enable them.
ignore = E125,E129,H # E402 - ansible modules put documentation before imports. Align to ansible.
ignore = E125,E129,E402,H
show-source = True show-source = True
exclude = .venv,.tox,dist,doc,build,*.egg exclude = .venv,.tox,dist,doc,build,*.egg