zuul/zuul-jobs
Code Issues Proposed changes

Split the log_path creation into its own role

Browse Source 
This is so that we can call it in the pre playbook for emitting info.
As part of doing this, use include_role to run it from upload-logs as it
always wants to be used there.

Change-Id: Ibd7d6bdb6275d052bcef2af068882e9b2876ef83
This commit is contained in:
Monty Taylor 2017-09-06 18:46:50 -05:00
parent 5083adc2a8
commit 97d5602faa
No known key found for this signature in database
GPG Key ID: 7BAE94BC7141A594
2 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
roles/generate-log-url/tasks/main.yaml Normal file
View File

@ -0,0 +1,9 @@
- name: Set log path for a change
when: zuul.change is defined
set_fact:
log_path: "{{ zuul.change[-2:] }}/{{ zuul.change }}/{{ zuul.patchset }}/{{ zuul.pipeline }}/{{ zuul.job }}/{{ zuul.build[:7] }}"
- name: Set log path for a ref update
when: zuul.newrev is defined
set_fact:
log_path: "{{ zuul.newrev[-2:] }}/{{ zuul.newrev }}/{{ zuul.pipeline }}/{{ zuul.job }}/{{ zuul.build[:7] }}"

11
roles/upload-logs/tasks/main.yaml
View File

@ -1,12 +1,5 @@
- name: Set log path for a change
when: zuul.change is defined
set_fact:
log_path: "{{ zuul.change[-2:] }}/{{ zuul.change }}/{{ zuul.patchset }}/{{ zuul.pipeline }}/{{ zuul.job }}/{{ zuul.build[:7] }}"
- name: Set log path for a ref update
when: zuul.newrev is defined
set_fact:
log_path: "{{ zuul.newrev[-2:] }}/{{ zuul.newrev }}/{{ zuul.pipeline }}/{{ zuul.job }}/{{ zuul.build[:7] }}"
- include_role:
name: generate-log-url
- name: Create log directories
file: