From 9a8b06fbc51aeb80036fccf9bc8dd614392a9805 Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Wed, 1 Feb 2023 16:24:01 +1100
Subject: [PATCH] container-roles-jobs: Update tests to jammy nodes

These build tests are all running on Bionic for no particular reason
other than it was recent at the time; update them to Jammy.

Because Jammy appears to have a too old systemd to properly support
podman and non root continers [0] our image builds don't work by
default. We need to override the cgroup manager to cgroupfs which is
less than ideal but should be functional.

[0] https://github.com/containers/podman/issues/7650

Change-Id: I18c56aea776e9ef102fe9020db592fb04df372e2
---
 roles/build-container-image/tasks/build.yaml |  3 +++
 zuul-tests.d/container-roles-jobs.yaml       | 10 +++++-----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/roles/build-container-image/tasks/build.yaml b/roles/build-container-image/tasks/build.yaml
index 37ebbfb15..e1bcd21ee 100644
--- a/roles/build-container-image/tasks/build.yaml
+++ b/roles/build-container-image/tasks/build.yaml
@@ -34,6 +34,9 @@
     tag_prefix: "{{ ('change_' + zuul.change) if (zuul.change is defined) else zuul.pipeline }}_"
   command: >-
     {{ container_command }} build {{ zj_image.path | default('.') }} {% if containerfile %}-f {{ containerfile }}{% endif %}
+    {% if container_command == 'podman' -%}
+      --cgroup-manager cgroupfs
+    {% endif -%}
     {% if zj_image.target | default(false) -%}
       --target {{ zj_image.target }}
     {% endif -%}
diff --git a/zuul-tests.d/container-roles-jobs.yaml b/zuul-tests.d/container-roles-jobs.yaml
index f7cccc6ce..ff9dd478b 100644
--- a/zuul-tests.d/container-roles-jobs.yaml
+++ b/zuul-tests.d/container-roles-jobs.yaml
@@ -126,7 +126,7 @@
     nodeset:
       nodes:
         - name: builder
-          label: ubuntu-bionic
+          label: ubuntu-jammy
 
 - job:
     name: zuul-jobs-test-build-docker-image-release
@@ -151,7 +151,7 @@
     nodeset:
       nodes:
         - name: builder
-          label: ubuntu-bionic
+          label: ubuntu-jammy
 
 - job:
     name: zuul-jobs-test-build-docker-image-release-multiarch
@@ -255,11 +255,11 @@
     nodeset:
       nodes:
         - name: intermediate-registry
-          label: ubuntu-bionic
+          label: ubuntu-jammy
         - name: executor
-          label: ubuntu-bionic
+          label: ubuntu-jammy
         - name: builder
-          label: ubuntu-bionic
+          label: ubuntu-jammy
 
 - job:
     name: zuul-jobs-test-registry-buildset-registry