Update javascript jobs to take npm_command variable

Similar to tox, the only difference in these is the command passed to
npm. Update the base job to do that, and the child jobs to use the
variable.

Change-Id: I5f9d420f1618e9a196b4218bca7055f377349351

playbooks/javascript/run-docs.yaml

@@ -1,4 +0,0 @@
-- hosts: all
-  roles:
-    - role: npm
-      npm_command: docs

playbooks/javascript/run-lint.yaml

@@ -1,4 +0,0 @@
-- hosts: all
-  roles:
-    - role: npm
-      npm_command: lint

playbooks/javascript/run-test.yaml

@@ -1,4 +0,0 @@
-- hosts: all
-  roles:
-    - role: npm
-      npm_command: test

playbooks/javascript/run.yaml

@@ -0,0 +1,3 @@
+- hosts: all
+  roles:
+    - npm

playbooks/javascript/tarball.yaml

@@ -1,4 +0,0 @@
-- hosts: all
-  roles:
-    - role: npm
-      npm_command: pack

zuul.yaml

@@ -231,12 +231,17 @@
     pre-run: playbooks/multinode/pre.yaml
 
 - job:
-    name: javascript-base
+    name: nodejs-npm
     description: |
       Base job for javascript operations
 
       Responds to these variables:
 
+      .. zuul:jobvar:: npm_command
+         :default: test
+
+         Command to pass to npm.
+
       .. zuul:jobvar:: node_version
          :default: 6
 
@@ -247,11 +252,14 @@
 
          Path to operate in.
     pre-run: playbooks/javascript/pre.yaml
+    run: playbooks/javascript/run.yaml
     post-run: playbooks/javascript/post.yaml
+    vars:
+      npm_command: test
 
 - job:
     name: build-javascript-tarball
-    parent: javascript-base
+    parent: nodejs-npm
     description: |
       Build a source tarball for a Javascript project
 
@@ -266,51 +274,67 @@
          :default: {{ zuul.project.src_dir }}
 
          Path to operate in.
-
-    run: playbooks/javascript/tarball.yaml
+    vars:
+      npm_command: pack
 
 - job:
     name: nodejs-npm-run-test
     description: |
       Run test using nodejs.
 
-      Responds to this variable:
+      Responds to these variables:
 
       .. zuul:jobvar:: node_version
          :default: 6
 
         The version of Node to use.
 
+      .. zuul:jobvar: zuul_work_dir
+         :default: {{ zuul.project.src_dir }}
+
+         Path to operate in.
     pre-run: playbooks/javascript/pre-test.yaml
     run: playbooks/javascript/run-test.yaml
     post-run: playbooks/javascript/post.yaml
 
 - job:
     name: nodejs-npm-run-lint
-    parent: javascript-base
+    parent: nodejs-npm
     description: |
       Run lint using nodejs.
 
-      Responds to this variable:
+      Responds to these variables:
 
       .. zuul:jobvar:: node_version
          :default: 6
 
          The version of Node to use.
-    run: playbooks/javascript/run-lint.yaml
+
+      .. zuul:jobvar: zuul_work_dir
+         :default: {{ zuul.project.src_dir }}
+
+         Path to operate in.
+    vars:
+      npm_command: lint
 
 - job:
     name: nodejs-npm-run-docs
-    parent: javascript-base
+    parent: nodejs-npm
     description: |
       Run docs using nodejs.
 
-      Responds to this variable:
+      Responds to these variables:
 
       .. zuul:jobvar:: node_version
          :default: 6
 
          The version of Node to use.
-    run: playbooks/javascript/run-docs.yaml
+
+      .. zuul:jobvar: zuul_work_dir
+         :default: {{ zuul.project.src_dir }}
+
+         Path to operate in.
     post-run: playbooks/tox/docs-post.yaml
     success-url: html/
+    vars:
+      npm_command: docs