From b6b6e36368db3a8d652a72cc4211bcc6ddee4f96 Mon Sep 17 00:00:00 2001
From: Ian Wienand <iwienand@redhat.com>
Date: Mon, 11 May 2020 10:59:36 +1000
Subject: [PATCH] ensure-pip: use full python3 path

As seen by Iaa3ecd05b64af6dd9b2ee17a39bcbe6cde8686ba "python3 -m venv
--help" doesn't actually tell you if the command will work, so it's
really not helpful.  Modify this to run the venv from the python in
the path.  This also expands the comments around why a full path is
necessary.

Change-Id: I03bded0345ff734fd6c5d02fdd44ed1cc14360d2
---
 roles/ensure-pip/tasks/main.yaml | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/roles/ensure-pip/tasks/main.yaml b/roles/ensure-pip/tasks/main.yaml
index ee768b059..6dfe8125a 100644
--- a/roles/ensure-pip/tasks/main.yaml
+++ b/roles/ensure-pip/tasks/main.yaml
@@ -49,17 +49,28 @@
     - pip_preinstalled.rc != 0
 
 #
-# virtualenv setup
+# Export a working virtualenv_command
 #
-- name: Probe for venv
-  command: /usr/bin/python3 -m venv --help
-  no_log: True
+
+# Ansible's "pip:" module looks at the virtualenv_command and, if it
+# isn't fully qualified, tries to find the command and add the leading
+# path for you.  However, it doesn't split it up; it will actually
+# look for a command "python3 -m venv" (not, as you'd want, just
+# "python") and everything fails.  Thus we find the full path to
+# python3 and build our default command for output.
+- name: Probe for venv python full path
+  shell: |
+    command -v python3
+  args:
+    executable: /bin/bash
+  tags:
+    - skip_ansible_lint  # command is a bash built-in
   failed_when: false
   register: _venv_probe
 
 - name: Set host default
   set_fact:
-    _host_virtualenv: '{{ (_venv_probe.rc == 0) | ternary("/usr/bin/python3 -m venv", "virtualenv") }}'
+    _host_virtualenv: '{{ (_venv_probe.rc == 0) | ternary(_venv_probe.stdout + " -m venv", "virtualenv") }}'
 
 - name: Set ensure_pip_virtualenv_cmd
   set_fact: