From bab30ca2cabe954d6f6a48fd0e6b1c0c22222208 Mon Sep 17 00:00:00 2001 From: Sorin Sbarnea Date: Wed, 19 Feb 2020 12:53:28 +0000 Subject: [PATCH] Improve ensure-tox role Avoid using ignore_errors for tasks that are likely to fail. Change-Id: I9eae9d96a3a8ed521b3c40356f95118a5647c7c1 --- test-playbooks/ensure-tox.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test-playbooks/ensure-tox.yaml b/test-playbooks/ensure-tox.yaml index 8d877c4c6..2f561b0c4 100644 --- a/test-playbooks/ensure-tox.yaml +++ b/test-playbooks/ensure-tox.yaml @@ -34,11 +34,11 @@ - name: Remove tox package with pip shell: pip uninstall -y tox become: true - ignore_errors: true + failed_when: false - name: Remove tox package with pip3 shell: pip3 uninstall -y tox become: true - ignore_errors: true + failed_when: false - name: Verify tox is not installed command: "tox --version" register: result @@ -49,8 +49,8 @@ tasks: - name: Remove tox package shell: pip uninstall tox || pip3 uninstall tox + failed_when: false become: true - ignore_errors: true - name: Verify tox is not installed command: "tox --version" register: result