Partial address ansible-lint E208

- replaces ignore with a warn, which displays issue without affecting
  the linting outcome (allowing gradual fixing)
- bumps linter to enable the warn_list feature
- fixes a set of issues, others will be fixed in follow-up

Change-Id: I7d6f8c156b06f68f681943e88860930968e7c9f9
This commit is contained in:
Clark Boylan 2020-08-27 09:28:41 -07:00 committed by Sorin Sbarnea
parent cbe1b4a5aa
commit d49893f894
10 changed files with 13 additions and 1 deletions

View File

@ -2,4 +2,4 @@
# conflict, like ansible version required by ansible-lint. # conflict, like ansible version required by ansible-lint.
flake8 flake8
yamllint>=1.23.0 yamllint>=1.23.0
ansible-lint>=4.3.0a1,<5 ansible-lint>=4.3.4,<5

View File

@ -25,3 +25,4 @@
section: main section: main
option: deltarpm option: deltarpm
value: 0 value: 0
mode: 0644

View File

@ -29,3 +29,4 @@
section: main section: main
option: deltarpm option: deltarpm
value: 0 value: 0
mode: 0644

View File

@ -25,3 +25,4 @@
section: main section: main
option: deltarpm option: deltarpm
value: "false" value: "false"
mode: 0644

View File

@ -13,6 +13,7 @@
file: file:
path: "{{ zuul_output_dir }}/{{ zj_output_dir }}" path: "{{ zuul_output_dir }}/{{ zj_output_dir }}"
state: directory state: directory
mode: 0755
with_items: with_items:
- logs - logs
- artifacts - artifacts

View File

@ -13,6 +13,7 @@
file: file:
path: "{{ zj_output_dir }}" path: "{{ zj_output_dir }}"
state: directory state: directory
mode: 0755
with_items: with_items:
- "{{ log_path }}" - "{{ log_path }}"
- "{{ zuul.executor.work_root }}/artifacts" - "{{ zuul.executor.work_root }}/artifacts"

View File

@ -16,6 +16,7 @@
file: file:
path: "{{ zuul.executor.work_root }}/artifacts" path: "{{ zuul.executor.work_root }}/artifacts"
state: directory state: directory
mode: 0755
delegate_to: localhost delegate_to: localhost
- name: Collect artifacts - name: Collect artifacts

View File

@ -4,6 +4,7 @@
file: file:
path: "{{ zuul_info_dir }}" path: "{{ zuul_info_dir }}"
state: directory state: directory
mode: 0755
# We don't use the ansible inventory_file variable because it is not defined # We don't use the ansible inventory_file variable because it is not defined
# for nodeless job running on the executor directly: # for nodeless job running on the executor directly:
@ -13,3 +14,4 @@
copy: copy:
src: "{{ zuul.executor.inventory_file }}" src: "{{ zuul.executor.inventory_file }}"
dest: "{{ zuul_info_dir }}" dest: "{{ zuul_info_dir }}"
mode: 0644

View File

@ -4,6 +4,7 @@
file: file:
path: "{{ afs_target }}" path: "{{ afs_target }}"
state: directory state: directory
mode: 0755
- name: Upload contents to AFS - name: Upload contents to AFS
synchronize: synchronize:
src: "{{ afs_source }}" src: "{{ afs_source }}"

View File

@ -8,6 +8,7 @@
file: file:
path: "{{ zuul_info_dir }}" path: "{{ zuul_info_dir }}"
state: directory state: directory
mode: 0755
- name: Collect information about the host - name: Collect information about the host
setup: setup:
@ -22,6 +23,7 @@
template: template:
dest: "{{ zuul_info_dir }}/host-info.{{ validate_host_hostname_sanitized }}.yaml" dest: "{{ zuul_info_dir }}/host-info.{{ validate_host_hostname_sanitized }}.yaml"
src: templates/host-info.j2 src: templates/host-info.j2
mode: 0644
- name: zuul_debug_info block - name: zuul_debug_info block
block: block:
@ -37,5 +39,6 @@
template: template:
dest: "{{ zuul_info_dir }}/zuul-info.{{ validate_host_hostname_sanitized }}.txt" dest: "{{ zuul_info_dir }}/zuul-info.{{ validate_host_hostname_sanitized }}.txt"
src: templates/zuul-info.j2 src: templates/zuul-info.j2
mode: 0644
when: ansible_python_version is version('2.7', '>=') when: ansible_python_version is version('2.7', '>=')