From db1629dc97020330df75261a8bbe04f423b25a71 Mon Sep 17 00:00:00 2001 From: Tobias Urdin Date: Mon, 21 Jan 2019 22:14:35 +0100 Subject: [PATCH] Use become for packages in upload-puppetforge The upload-puppetforge role when executed as a unprivileged user fails to install system packages and the gems in the system gem home, see failure [1]. This adds become to the calls so that it becomes the privileged user and executes these which will make them have system access like the bindep role [2]. [1] http://logs.openstack.org/61/617ffad84b633618490ca1023f8a31d9694b31a9/release/release-openstack-puppet/c6e519d/job-output.txt.gz#_2019-01-21_20_53_17_207155 [2] https://git.openstack.org/cgit/openstack-infra/zuul-jobs/tree/roles/bindep/tasks/packages.yaml#n6 Change-Id: I4f11319727a4a5694f11abad4ded69ee554326f2 --- roles/upload-puppetforge/tasks/main.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roles/upload-puppetforge/tasks/main.yaml b/roles/upload-puppetforge/tasks/main.yaml index d8e7fc7c2..3003ce20b 100644 --- a/roles/upload-puppetforge/tasks/main.yaml +++ b/roles/upload-puppetforge/tasks/main.yaml @@ -5,6 +5,7 @@ - gcc-c++ - make state: present + become: yes when: ansible_os_family == "RedHat" or ansible_os_family == "Suse" - name: Install ruby dependencies on Debian based @@ -14,6 +15,7 @@ - g++ - make state: present + become: yes when: ansible_os_family == "Debian" - name: Install required gems @@ -24,6 +26,7 @@ - rake - puppetlabs_spec_helper - puppet-blacksmith + become: yes # NOTE(tobias.urdin): The build task is needed because puppet-blacksmith # doesn't provide a build task so it fails, we don't need one anyway since