go: Use 'block: ... always: ...' and failed_when instead of ignore_errors

Change-Id: I11fc6ec69eda00f4ac824f27712acc82ec445f79

roles/ensure-go/tasks/main.yaml

@@ -3,7 +3,7 @@
   register: go_installed_version
   environment:
     PATH: "{{ ansible_env.PATH }}:{{ go_install_dir }}/go/bin"
-  ignore_errors: yes
+  failed_when: false
 
 - name: Skip if correct version of go is installed
   include_tasks: install-go.yaml

roles/golangci-lint/tasks/main.yaml

@@ -1,27 +1,23 @@
-- name: Run golangci-lint
+- block:
+    - name: Run golangci-lint
       command: "golangci-lint run {{ golangci_lint_options }}"
       args:
         chdir: "{{ zuul_work_dir }}"
       environment:
         PATH: "{{ ansible_env.PATH }}:{{ go_bin_path }}"
-  ignore_errors: true
       register: _golangci_lint
 
-- name: Look for output
+  always:
+    - name: Look for output
       golangci_lint_parse_output:
         workdir: '{{ zuul_work_dir }}'
         output: '{{ _golangci_lint.stdout }}'
       register: _golangci_lint_parse_output
 
-- name: Return file comments to Zuul
+    - name: Return file comments to Zuul
       when: _golangci_lint_parse_output.comments
       delegate_to: localhost
       zuul_return:
         data:
           zuul:
             file_comments: '{{ _golangci_lint_parse_output.comments }}'
-
-- name: Return golangci-lint status
-  fail:
-    msg: 'golangci-lint exited with return code {{ _golangci_lint.rc }}'
-  when: _golangci_lint.rc != 0