zuul/zuul-preview
Code Issues Proposed changes

Get rid of -Wmissing-declaration

Browse Source 
The extra line just looks weird.
This commit is contained in:
Monty Taylor 2019-02-09 21:48:47 +00:00
parent d58179dba7
commit 5302413002
2 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
m4/pandora_warnings.m4
View File

@ -240,25 +240,6 @@ uint16_t x= htons(80);
CC_WARNINGS="${BASE_WARNINGS} -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wmissing-declarations -Wcast-align ${CC_WARNINGS_FULL}"
CXX_WARNINGS="${BASE_WARNINGS} -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy ${CXX_WARNINGS_FULL}"
AC_CACHE_CHECK([whether it is safe to use -Wmissing-declarations from C++],
[ac_cv_safe_to_use_Wmissing_declarations_],
[AC_LANG_PUSH(C++)
save_CXXFLAGS="$CXXFLAGS"
CXXFLAGS="-Werror -pedantic -Wmissing-declarations ${AM_CXXFLAGS}"
AC_COMPILE_IFELSE([
AC_LANG_PROGRAM(
[[
#include <stdio.h>
]], [[]])
],
[ac_cv_safe_to_use_Wmissing_declarations_=yes],
[ac_cv_safe_to_use_Wmissing_declarations_=no])
CXXFLAGS="$save_CXXFLAGS"
AC_LANG_POP()
])
AS_IF([test "$ac_cv_safe_to_use_Wmissing_declarations_" = "yes"],
[CXX_WARNINGS="${CXX_WARNINGS} -Wmissing-declarations"])
AC_CACHE_CHECK([whether it is safe to use -Wframe-larger-than],
[ac_cv_safe_to_use_Wframe_larger_than_],
[AC_LANG_PUSH(C++)

2
zuul-preview/main.cc
View File

@ -23,8 +23,6 @@
using namespace std;
vector<string> split(string in);
vector<string> split(string in)
{
istringstream stream(in);