zuul/zuul-registry
Code Issues Proposed changes

Fix range response

Browse Source 
The range starts from zero, so we are returning one byte too many.
Docker echos this back to us in the manifest it uploads which is where
the extra byte is coming from.

This is actually the root cause of the off-by-one error worked around
in 134c9428353247c22b69f497b904593faf93292d.  A follow-on will clean
this up (Ibe061171bfd8ab6043b491bbab933bf277f8e12b).

Change-Id: I1fb1abf3c76ea8db7820caa90c97ddbf92997842
This commit is contained in:
Ian Wienand 2021-09-13 13:08:02 +10:00 committed by Clark Boylan
parent 7100c360b3
commit ce2fb31a72
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zuul_registry/main.py
View File

@ -271,7 +271,8 @@ class RegistryAPI:
orig_repository, uuid)
res.headers['Docker-Upload-UUID'] = uuid
res.headers['Content-Length'] = '0'
res.headers['Range'] = '0-%s' % (new_length,)
# Be careful to not be off-by-one, range starts at 0
res.headers['Range'] = '0-%s' % (new_length - 1,)
res.status = '202 Accepted'
self.log.info(
'[u: %s] Finish Upload chunk %s %s', uuid, repository, new_length)