opendev/system-config
Code Issues Proposed changes

Add plain gerrit trigger comment

Browse Source 
Use this on all non-merge jobs

Fixes bug #988584

Change-Id: Ia9bfecc872b63fd53da0be6f6063b3db66dfeac2
This commit is contained in:
Andrew Hutchings 2012-05-02 16:38:02 +01:00
parent e5b3600b5c
commit 22532c53f6
6 changed files with 34 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/jenkins_jobs/manifests/jobs/merge_gate.pp
View File

@ -5,7 +5,7 @@ define jenkins_jobs::jobs::merge_gate($site, $project, $node_group, $trigger_bra
project => $project, project => $project,
job => "merge", job => "merge",
node_group => $node_group, node_group => $node_group,
triggers => trigger("gerrit_comment"), triggers => trigger("gerrit_comment_merge"),
builders => builder("gerrit_git_prep"), builders => builder("gerrit_git_prep"),
trigger_branches => $trigger_branches, trigger_branches => $trigger_branches,
auth_build => true auth_build => true

2
modules/jenkins_jobs/manifests/jobs/pep8_gate.pp
View File

@ -5,7 +5,7 @@ define jenkins_jobs::jobs::pep8_gate($site, $project, $node_group, $trigger_bran
project => $project, project => $project,
job => "pep8", job => "pep8",
node_group => $node_group, node_group => $node_group,
triggers => trigger("gerrit_comment"), triggers => trigger("gerrit_comment_plain"),
builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("pep8")], builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("pep8")],
publishers => publisher("pep8"), publishers => publisher("pep8"),
trigger_branches => $trigger_branches, trigger_branches => $trigger_branches,

2
modules/jenkins_jobs/manifests/jobs/python26_gate.pp
View File

@ -5,7 +5,7 @@ define jenkins_jobs::jobs::python26_gate($site, $project, $node_group, $trigger_
project => $project, project => $project,
job => "python26", job => "python26",
node_group => $node_group, node_group => $node_group,
triggers => trigger("gerrit_comment"), triggers => trigger("gerrit_comment_plain"),
builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("python26")], builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("python26")],
trigger_branches => $trigger_branches, trigger_branches => $trigger_branches,
auth_build => true auth_build => true

2
modules/jenkins_jobs/manifests/jobs/python27_gate.pp
View File

@ -5,7 +5,7 @@ define jenkins_jobs::jobs::python27_gate($site, $project, $node_group, $trigger_
project => $project, project => $project,
job => "python27", job => "python27",
node_group => $node_group, node_group => $node_group,
triggers => trigger("gerrit_comment"), triggers => trigger("gerrit_comment_plain"),
builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("python27")], builders => [builder("gerrit_git_prep"), builder("copy_bundle"), builder("python27")],
trigger_branches => $trigger_branches, trigger_branches => $trigger_branches,
auth_build => true auth_build => true

0
modules/jenkins_jobs/templates/trigger_gerrit_comment.xml.erb → modules/jenkins_jobs/templates/trigger_gerrit_comment_merge.xml.erb
View File

30
modules/jenkins_jobs/templates/trigger_gerrit_comment_plain.xml.erb Normal file
View File

@ -0,0 +1,30 @@
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger>
<spec></spec>
<gerritProjects>
<% trigger_branches.each do |trigger| %>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
<compareType>PLAIN</compareType>
<pattern><%= site %>/<%= trigger[0] %></pattern>
<branches>
<com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch>
<compareType>ANT</compareType>
<pattern><%= trigger[1] %></pattern>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.Branch>
</branches>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.data.GerritProject>
<% end %>
</gerritProjects>
<silentMode>false</silentMode>
<escapeQuotes>true</escapeQuotes>
<triggerOnPatchsetUploadedEvent>false</triggerOnPatchsetUploadedEvent>
<triggerOnChangeMergedEvent>false</triggerOnChangeMergedEvent>
<triggerOnCommentAddedEvent>true</triggerOnCommentAddedEvent>
<triggerOnRefUpdatedEvent>false</triggerOnRefUpdatedEvent>
<commentAddedTriggerApprovalCategory>APRV</commentAddedTriggerApprovalCategory>
<commentAddedTriggerApprovalValue>1</commentAddedTriggerApprovalValue>
<buildStartMessage></buildStartMessage>
<buildFailureMessage></buildFailureMessage>
<buildSuccessfulMessage></buildSuccessfulMessage>
<buildUnstableMessage></buildUnstableMessage>
<customUrl></customUrl>
</com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTrigger>