opendev/system-config
Code Issues Proposed changes

Make localuser gid and uid required params

Browse Source 
Before we had set gid and uid to unset by default. Which if not
overridden will have puppet try to set the gid and uid values to
'unset'. This should be an error as 'unset' is not a number. We don't
have this error because we always override these values when creating
localusers. But for completeness and better error messages remove the
default values so that puppet requires users to have proper gid and uid
values.

Change-Id: I14667912b9239ea1c56123c18b0c13834f9c3cb6
This commit is contained in:
Clark Boylan 2014-12-09 09:50:30 -08:00
parent 1d5e2e9039
commit 7551e1cfa1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/user/manifests/virtual/localuser.pp
View File

@ -4,14 +4,14 @@
define user::virtual::localuser( define user::virtual::localuser(
$realname, $realname,
$uid,
$gid,
$groups = [ 'sudo', 'admin', ], $groups = [ 'sudo', 'admin', ],
$sshkeys = '', $sshkeys = '',
$key_id = '', $key_id = '',
$old_keys = [], $old_keys = [],
$shell = '/bin/bash', $shell = '/bin/bash',
$home = "/home/${title}", $home = "/home/${title}",
$uid = unset,
$gid = unset,
$managehome = true $managehome = true
) { ) {