openinfra/refstack
Code Issues Proposed changes

Add a check for nonexistent capabilities

Browse Source 
On the results report page, for schema versions 1.3 and
above, a check is added to check if a capability listed in
the components section is also in the capabilities object.
This will prevent the parsing from erroring out.

Change-Id: If6e1ab8d73e6cd6aacfa1e38847c9d838f6d9877
This commit is contained in:
Paul Van Eck 2017-01-24 11:58:46 -08:00
parent 0d46eb45f1
commit 41a4565c9f
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
refstack-ui/app/components/results-report/resultsReportController.js
View File

@ -348,6 +348,13 @@
'passedFlagged': [],
'notPassedFlagged': []
};
// For cases where a capability listed in components is not
// in the capabilities object.
if (!(capId in ctrl.guidelineData.capabilities)) {
return cap;
}
// Loop through each test belonging to the capability.
angular.forEach(ctrl.guidelineData.capabilities[capId].tests,
function (details, testId) {

13
refstack-ui/tests/unit/ControllerSpec.js
View File

@ -554,6 +554,19 @@ describe('Refstack controllers', function () {
expect(ctrl.caps).toEqual(expectedCapsObject);
expect(ctrl.requiredPassPercent).toEqual(75);
expect(ctrl.nonFlagPassCount).toEqual(2);
// Test case where a component capability isn't listed in
// the capabilities object.
ctrl.guidelineData.components.compute.removed = ['fake_cap'];
ctrl.buildCapabilitiesObject();
expectedCapsObject.removed.caps = [{
'id': 'fake_cap',
'passedTests': [],
'notPassedTests': [],
'passedFlagged': [],
'notPassedFlagged': []
}];
expect(ctrl.caps).toEqual(expectedCapsObject);
});
it('should have a method to determine if a test is flagged',