openstack/bifrost
Code Issues Proposed changes

Better explanatory message for pip install

Browse Source 
Update comment text to reflect why we install pip the
way we do.

Change-Id: Id711b99932e5166f4ab9ce6f9d70bd8c66604ae3
Closes-Bug: #1536627
This commit is contained in:
stephane 2016-02-18 19:33:51 -08:00
parent 552b09cb12
commit d15756b32b
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
scripts/env-setup.sh
View File

@ -82,12 +82,13 @@ PYTHON=$(which python)
# We can't use the apt packaged version of pip since # We can't use the apt packaged version of pip since
# older versions of pip are incompatible with # older versions of pip are incompatible with
# requests, one of our indirect dependencies (bug 1459947). # requests, one of our indirect dependencies (bug 1459947).
#
# Note(TheJulia) This originally appeared because older # Note(cinerama): We use pip to install an updated pip plus our
# versions of pip would do the wrong thing, 1459947. # other python requirements. pip breakages can seriously impact us,
# However, now pip 8.0 breaks things. See 1536627 # so we've chosen to install/upgrade pip here rather than in
#wget -O /tmp/get-pip.py https://bootstrap.pypa.io/get-pip.py # requirements (which are synced automatically from the global ones)
#sudo -H -E python /tmp/get-pip.py # so we can quickly and easily adjust version parameters.
# See bug 1536627.
if ! which pip; then if ! which pip; then
wget -O /tmp/get-pip.py https://bootstrap.pypa.io/get-pip.py wget -O /tmp/get-pip.py https://bootstrap.pypa.io/get-pip.py