openstack/ironic
Code Issues Proposed changes

Silence F405 errors

Browse Source 
The F405 errors that were present in our
repository are a common pattern for ansible
modules. As such, They have been marked for
noqa.

Change-Id: Ie161bf38b00f5e798a470b16700925f9ef7b322d
Story: #2001985
This commit is contained in:
Julia Kreger 2018-05-08 12:42:34 -07:00
parent 24c04d93dd
commit 5839bbad39
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/drivers/modules/ansible/playbooks/library/facts_wwn.py
View File

@ -47,7 +47,7 @@ def get_devices_wwn(devices, module):
def main(): def main():
module = AnsibleModule( module = AnsibleModule( # noqa This is normal for Ansible modules.
argument_spec=dict( argument_spec=dict(
devices=dict(required=True, type='list'), devices=dict(required=True, type='list'),
), ),

2
ironic/drivers/modules/ansible/playbooks/library/root_hints.py
View File

@ -61,7 +61,7 @@ def root_hint(hints, devices):
def main(): def main():
module = AnsibleModule( module = AnsibleModule( # noqa This is normal for Ansible modules.
argument_spec=dict( argument_spec=dict(
root_device_hints=dict(required=True, type='dict'), root_device_hints=dict(required=True, type='dict'),
ansible_devices=dict(required=True, type='dict'), ansible_devices=dict(required=True, type='dict'),

2
ironic/drivers/modules/ansible/playbooks/library/stream_url.py
View File

@ -60,7 +60,7 @@ def stream_to_dest(url, dest, chunksize, hash_algo, verify=True, certs=None):
def main(): def main():
module = AnsibleModule( module = AnsibleModule( # noqa This is normal for Ansible modules.
argument_spec=dict( argument_spec=dict(
url=dict(required=True, type='str'), url=dict(required=True, type='str'),
dest=dict(required=True, type='str'), dest=dict(required=True, type='str'),

4
tox.ini
View File

@ -106,9 +106,9 @@ commands = {posargs}
[flake8] [flake8]
# [W503] Line break before binary operator. # [W503] Line break before binary operator.
# NOTE(TheJulia): Adding W606,E501,F405 to the ignore list # NOTE(TheJulia): Adding W606,E501 to the ignore list
# until we are able to clean them up in the code base. # until we are able to clean them up in the code base.
ignore = E129,W503,W606,E501,F405 ignore = E129,W503,W606,E501
filename = *.py,app.wsgi filename = *.py,app.wsgi
exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build exclude = .venv,.git,.tox,dist,doc,*lib/python*,*egg,build
import-order-style = pep8 import-order-style = pep8