openstack/kolla-ansible
Code Issues Proposed changes

ansible-lint: cleanup our skip list

Browse Source 
removed:
- 701 [galaxy_info missing] is no longer emited
- 602 [empty string compare] is now opt-in
- 208 [permissions not mentioned] is no longer emited
- 106 [role name] is no longer emited

renamed from number to role name:
- 503 [no-handler]
- 301 [no-changed-when]

Change-Id: I8b059d87c94499decbd9b115ef2cde033aa88fbd
This commit is contained in:
Marcin Juszkiewicz 2022-09-26 11:40:57 +02:00
parent e890f161ed
commit 387de84520
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.ansible-lint
View File

@ -1,21 +1,11 @@
--- ---
use_default_rules: true use_default_rules: true
skip_list: skip_list:
# [E701] galaxy_info missing in metadata
- '701'
# [E602] https://github.com/ansible/ansible-lint/issues/457
- '602'
# [E301] Commands should not change things if nothing needs doing # [E301] Commands should not change things if nothing needs doing
# TODO(mnasiadka): Fix tasks that fail this check in a later iteration # TODO(mnasiadka): Fix tasks that fail this check in a later iteration
- '301' - no-changed-when
# [E503] Tasks that run when changed should likely be handlers # [E503] Tasks that run when changed should likely be handlers
# TODO(mnasiadka): Rework baremetal role to do handlers instead of when: *.changed - no-handler
- '503'
# [E106] Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern
- '106'
# [E208] permissions not mentioned
# FIXME(mnasiadka): Rework file/template to include permissions
- '208'
# [unnamed-task] All tasks should be named # [unnamed-task] All tasks should be named
# FIXME(mgoddard): Add names to all tasks # FIXME(mgoddard): Add names to all tasks
- unnamed-task - unnamed-task