openstack/kolla-ansible
Code Issues Proposed changes

Merge "Replace always_run by check_mode"

Browse Source
This commit is contained in:
Jenkins 2017-06-16 07:17:55 +00:00 committed by Gerrit Code Review
commit 93bcf4b16a
4 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ansible/roles/ceph/tasks/bootstrap_mons.yml
View File

@ -2,13 +2,13 @@
- name: Cleaning up temp file on localhost - name: Cleaning up temp file on localhost
local_action: file path=/tmp/kolla_ceph_cluster state=absent local_action: file path=/tmp/kolla_ceph_cluster state=absent
changed_when: False changed_when: False
always_run: True check_mode: no
run_once: True run_once: True
- name: Creating temp file on localhost - name: Creating temp file on localhost
local_action: copy content=None dest=/tmp/kolla_ceph_cluster mode=0644 local_action: copy content=None dest=/tmp/kolla_ceph_cluster mode=0644
changed_when: False changed_when: False
always_run: True check_mode: no
run_once: True run_once: True
- name: Creating ceph_mon_config volume - name: Creating ceph_mon_config volume
@ -21,7 +21,7 @@
- name: Writing hostname of host with existing cluster files to temp file - name: Writing hostname of host with existing cluster files to temp file
local_action: copy content="{{ inventory_hostname }}" dest=/tmp/kolla_ceph_cluster mode=0644 local_action: copy content="{{ inventory_hostname }}" dest=/tmp/kolla_ceph_cluster mode=0644
changed_when: False changed_when: False
always_run: True check_mode: no
when: not ceph_mon_config_volume.changed when: not ceph_mon_config_volume.changed
- name: Registering host from temp file - name: Registering host from temp file
@ -31,7 +31,7 @@
- name: Cleaning up temp file on localhost - name: Cleaning up temp file on localhost
local_action: file path=/tmp/kolla_ceph_cluster state=absent local_action: file path=/tmp/kolla_ceph_cluster state=absent
changed_when: False changed_when: False
always_run: True check_mode: no
run_once: True run_once: True
- include: generate_cluster.yml - include: generate_cluster.yml

8
ansible/roles/haproxy/tasks/precheck.yml
View File

@ -9,17 +9,17 @@
- name: Clearing temp kolla_keepalived_running file - name: Clearing temp kolla_keepalived_running file
local_action: file path=/tmp/kolla_keepalived_running state=absent local_action: file path=/tmp/kolla_keepalived_running state=absent
changed_when: False changed_when: False
always_run: True check_mode: no
- name: Create empty temp kolla_keepalived_running file - name: Create empty temp kolla_keepalived_running file
local_action: copy content=None dest=/tmp/kolla_keepalived_running mode=0644 local_action: copy content=None dest=/tmp/kolla_keepalived_running mode=0644
changed_when: False changed_when: False
always_run: True check_mode: no
- name: Getting hosts who is running keepalived - name: Getting hosts who is running keepalived
local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_keepalived_running mode=0644 local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_keepalived_running mode=0644
changed_when: False changed_when: False
always_run: True check_mode: no
when: when:
- inventory_hostname in groups['haproxy'] - inventory_hostname in groups['haproxy']
- container_facts['keepalived'] is defined - container_facts['keepalived'] is defined
@ -32,7 +32,7 @@
- name: Clearing temp kolla_keepalived_running file - name: Clearing temp kolla_keepalived_running file
local_action: file path=/tmp/kolla_keepalived_running state=absent local_action: file path=/tmp/kolla_keepalived_running state=absent
changed_when: False changed_when: False
always_run: True check_mode: no
- name: Checking the kolla_external_vip_interface is present - name: Checking the kolla_external_vip_interface is present
fail: "msg='Please check the kolla_external_vip_interface property - interface {{ kolla_external_vip_interface }} not found'" fail: "msg='Please check the kolla_external_vip_interface property - interface {{ kolla_external_vip_interface }} not found'"

8
ansible/roles/mariadb/tasks/lookup_cluster.yml
View File

@ -2,13 +2,13 @@
- name: Cleaning up temp file on localhost - name: Cleaning up temp file on localhost
local_action: file path=/tmp/kolla_mariadb_cluster state=absent local_action: file path=/tmp/kolla_mariadb_cluster state=absent
changed_when: False changed_when: False
always_run: True check_mode: no
run_once: True run_once: True
- name: Creating temp file on localhost - name: Creating temp file on localhost
local_action: copy content=None dest=/tmp/kolla_mariadb_cluster mode=0644 local_action: copy content=None dest=/tmp/kolla_mariadb_cluster mode=0644
changed_when: False changed_when: False
always_run: True check_mode: no
run_once: True run_once: True
- name: Creating mariadb volume - name: Creating mariadb volume
@ -21,7 +21,7 @@
- name: Writing hostname of host with existing cluster files to temp file - name: Writing hostname of host with existing cluster files to temp file
local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_mariadb_cluster mode=0644 local_action: copy content={{ ansible_hostname }} dest=/tmp/kolla_mariadb_cluster mode=0644
changed_when: False changed_when: False
always_run: True check_mode: no
when: not mariadb_volume | changed when: not mariadb_volume | changed
- name: Registering host from temp file - name: Registering host from temp file
@ -31,5 +31,5 @@
- name: Cleaning up temp file on localhost - name: Cleaning up temp file on localhost
local_action: file path=/tmp/kolla_mariadb_cluster state=absent local_action: file path=/tmp/kolla_mariadb_cluster state=absent
changed_when: False changed_when: False
always_run: True check_mode: no
run_once: True run_once: True

8
ansible/roles/mariadb/tasks/recover_cluster.yml
View File

@ -17,12 +17,12 @@
- name: Cleaning up temp file on mariadb hosts - name: Cleaning up temp file on mariadb hosts
file: path=/tmp/kolla_mariadb_grastate.dat state=absent file: path=/tmp/kolla_mariadb_grastate.dat state=absent
changed_when: false changed_when: false
always_run: true check_mode: no
- name: Cleaning up temp file on localhost - name: Cleaning up temp file on localhost
local_action: file path=/tmp/kolla_mariadb_recover_inventory_name state=absent local_action: file path=/tmp/kolla_mariadb_recover_inventory_name state=absent
changed_when: false changed_when: false
always_run: true check_mode: no
run_once: true run_once: true
- block: - block:
@ -60,12 +60,12 @@
- name: Cleaning up temp file on mariadb hosts - name: Cleaning up temp file on mariadb hosts
file: path=/tmp/kolla_mariadb_grastate.dat state=absent file: path=/tmp/kolla_mariadb_grastate.dat state=absent
changed_when: false changed_when: false
always_run: true check_mode: no
- name: Cleaning up temp file on localhost - name: Cleaning up temp file on localhost
local_action: file path=/tmp/kolla_mariadb_recover_inventory_name state=absent local_action: file path=/tmp/kolla_mariadb_recover_inventory_name state=absent
changed_when: false changed_when: false
always_run: true check_mode: no
run_once: true run_once: true
- name: Starting first MariaDB container - name: Starting first MariaDB container