openstack/openstack-ansible-os_ironic
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false'

Browse Source 
This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: I7067a541362c826579fc7d17abf86fe9ddc89bee
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-10-14 16:45:32 -05:00
parent a7e96f6189
commit 3a62eccb2c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tasks/ironic_install.yml
View File

@ -89,7 +89,7 @@
url: "{{ ironic_venv_download_url }}"
dest: "/var/cache/{{ ironic_venv_download_url | basename }}"
force: yes
ignore_errors: true
failed_when: false
register: get_venv
when:
- not ironic_developer_mode | bool