openstack/openstack-helm-infra
Code Issues Proposed changes

lint: enable running on changed charts only

Browse Source 
At the moment, we are using --all which means run the linting on all of
the charts.  However, the problem with using --all is that it disables
version checking which means we can't enforce version changes on Helm
charts.

This patch drops it which means the chart-testing logic will go over the
changed files and make sure that it lints those charts which have
undergone changes.

Because we use a mdoel of 1 commit per merge within Gerrit, this should
still give us the exact coverage that we need without potentially
missing any linting changes.

Change-Id: I64c7896b25c1f3daaa4f61723de8a6c722aaf3a6
This commit is contained in:
Mohammed Naser 2020-09-17 13:50:26 -04:00
parent 2bfce96304
commit d4e2228f03
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/lint.yml
View File

@ -22,7 +22,7 @@
when: "zuul.project.name == 'openstack/openstack-helm'" when: "zuul.project.name == 'openstack/openstack-helm'"
- ensure-chart-testing - ensure-chart-testing
- name: chart-testing - name: chart-testing
chart_testing_options: "--chart-dirs=. --validate-maintainers=false --all" chart_testing_options: "--chart-dirs=. --validate-maintainers=false"
zuul_work_dir: "{{ work_dir }}" zuul_work_dir: "{{ work_dir }}"
vars: vars:
work_dir: "{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default('') }}" work_dir: "{{ zuul.project.src_dir }}/{{ zuul_osh_infra_relative_path | default('') }}"