openstack/oslo.messaging
Code Issues Proposed changes

Deprecate the option heartbeat_in_pthread.

Browse Source 
The option is strongly related to Eventlet. Eventlet will be removed
and the option have never worked as excepted.

Change-Id: Ide8b22e2c66eae6639266950a39c4042d9a656fd
This commit is contained in:
damani42 2024-08-06 16:56:04 +02:00 committed by Takashi Kajinami
parent 104a63b9aa
commit 133ca65fa4
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
oslo_messaging/_drivers/impl_rabbit.py
View File

@ -93,7 +93,13 @@ rabbit_opts = [
'an exception will be raised.'), 'an exception will be raised.'),
cfg.BoolOpt('heartbeat_in_pthread', cfg.BoolOpt('heartbeat_in_pthread',
default=False, default=False,
help="Run the health check heartbeat thread " deprecated_for_removal=True,
deprecated_reason='The option is related to Eventlet which '
'will be removed. In addition this has '
'never worked as expected with services '
'using eventlet for core service framework.',
help="(DEPRECATED) It is recommend not to use this option "
"anymore. Run the health check heartbeat thread "
"through a native python thread by default. If this " "through a native python thread by default. If this "
"option is equal to False then the health check " "option is equal to False then the health check "
"heartbeat will inherit the execution model " "heartbeat will inherit the execution model "

8
releasenotes/notes/deprecate-the-option-heartbeat_in_pthread-from-rabbit-driver-5757adb83701caa5.yaml Normal file
View File

@ -0,0 +1,8 @@
---
deprecations:
- |
The ``heartbeat_in_pthread`` option from the rabbitmq driver has been
deprecated and it is recommended not to use the feature anymore.
The option is strongly related to Eventlet but Eventlet will be removed
from OpenStack services in a future release. In addition, this feature has
never worked with services using eventlet for core service framework.