b87fd91156
* Remove tests/unit/aas and test/unit/fixture fixtures are not used so just remove them aas - didn't have __init__.py files so these tests were not executed at all. By the way code related to this tests was removed earlier in this patch: https://review.openstack.org/#/c/152847/ * Remove all old py3 related hacking rules Now we have unit & functional jobs that checks them * Add new hacking rule that protect us from usage of ' * Unified signature of all hacking methods (otherwise we are not able to make decorator) * Add hacking rules decorator for skiping 3 types of lines: empty, commented, and with # noqa comment Change-Id: I6bf2cc123325a4980edeb066a6c31aa685858f5b
27 lines
1.5 KiB
ReStructuredText
27 lines
1.5 KiB
ReStructuredText
Rally Style Commandments
|
|
========================
|
|
|
|
- Step 1: Read the OpenStack Style Commandments
|
|
http://docs.openstack.org/developer/hacking/
|
|
- Step 2: Read on
|
|
|
|
Rally Specific Commandments
|
|
---------------------------
|
|
* [N30x] - Reserved for rules related to ``mock`` library
|
|
* [N301] - Ensure that ``assert_*`` methods from ``mock`` library is used correctly
|
|
* [N302] - Ensure that nonexistent "assert_called" is not used
|
|
* [N303] - Ensure that nonexistent "assert_called_once" is not used
|
|
* [N310-N314] - Reserved for rules related to logging
|
|
* [N310] - Ensure that ``rally.common.log`` is used as logging module
|
|
* [N311] - Validate that debug level logs are not translated
|
|
* [N312] - Validate correctness of debug on check.
|
|
* [N32x] - Reserved for rules related to assert* methods
|
|
* [N320] - Ensure that ``assertTrue(isinstance(A, B))`` is not used
|
|
* [N321] - Ensure that ``assertEqual(type(A), B)`` is not used
|
|
* [N322] - Ensure that ``assertEqual(A, None)`` and ``assertEqual(None, A)`` are not used
|
|
* [N323] - Ensure that ``assertTrue/assertFalse(A in/not in B)`` are not used with collection contents
|
|
* [N324] - Ensure that ``assertEqual(A in/not in B, True/False)`` and ``assertEqual(True/False, A in/not in B)`` are not used with collection contents
|
|
* [N340] - Ensure that we are importing always ``from rally import objects``
|
|
* [N341] - Ensure that we are importing oslo_xyz packages instead of deprecated oslo.xyz ones
|
|
* [N350] - Ensure that single quotes are not used
|