openstack/shade
Code Issues Proposed changes

Add constructor param to turn on inner logging

Browse Source 
Monkeypatching isn't the best interface for setting a behavior flag.
Make it more accessible by presenting it as a constructor option.

Change-Id: Icc6b87c205fff551351cad81b9d83c27fc67d2c9
This commit is contained in:
Monty Taylor 2016-03-19 08:12:45 -05:00
parent 4151feb65c
commit d725978313
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
shade/openstackcloud.py
View File

@ -102,6 +102,15 @@ class OpenStackCloud(object):
OpenStack API tasks. Unless you're doing
rate limiting client side, you almost
certainly don't need this. (optional)
:param bool log_inner_exceptions: Send wrapped exceptions to the error log.
Defaults to false, because there are a
number of wrapped exceptions that are
noise for normal usage. It's possible
that for a user that has python logging
configured properly, it's desirable to
have all of the wrapped exceptions be
emitted to the error log. This flag
will enable that behavior.
:param CloudConfig cloud_config: Cloud config object from os-client-config
In the future, this will be the only way
to pass in cloud configuration, but is
@ -111,7 +120,10 @@ class OpenStackCloud(object):
def __init__(
self,
cloud_config=None,
manager=None, **kwargs):
manager=None, log_inner_exceptions=False, **kwargs):
if log_inner_exceptions:
OpenStackCloudException.log_inner_exceptions = True
self.log = _log.setup_logging('shade')
if not cloud_config: