x/stackalytics
Code Issues Proposed changes

Use assertTrue/False instead of assertEqual(T/F)

Browse Source 
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I144e949275f196a5826e2963515fd38f4dbf9286
Closes-Bug: #1512207
This commit is contained in:
Yatin Kumbhare 2016-01-06 15:30:23 +05:30
parent b9c04403d0
commit 5f96b1f7ac
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
stackalytics/tests/unit/test_driverlog.py
View File

@ -100,7 +100,7 @@ class TestDriverlog(testtools.TestCase):
res = list(driverlog.log([review], drivers))
self.assertEqual(1, len(res), 'One CI result is expected')
self.assertEqual(False, res[0]['value'])
self.assertFalse(res[0]['value'])
def test_find_ci_result_non_existent(self):
drivers = [DRIVER_NON_EXISTENT]
@ -123,4 +123,4 @@ class TestDriverlog(testtools.TestCase):
res = list(driverlog.log([review], drivers))
self.assertEqual(1, len(res), 'One CI result is expected')
self.assertEqual(True, res[0]['value'])
self.assertTrue(res[0]['value'])

4
stackalytics/tests/unit/test_rcs.py
View File

@ -43,7 +43,7 @@ class TestRcs(testtools.TestCase):
gerrit = rcs.Gerrit('gerrit://review.openstack.org')
setup_result = gerrit.setup(username='user', key_filename='key')
self.assertEqual(True, setup_result)
self.assertTrue(setup_result)
mock_connect.assert_called_once_with(
'review.openstack.org', port=rcs.DEFAULT_PORT, key_filename='key',
username='user')
@ -60,7 +60,7 @@ class TestRcs(testtools.TestCase):
gerrit = rcs.Gerrit('gerrit://review.openstack.org')
setup_result = gerrit.setup(username='user', key_filename='key')
self.assertEqual(False, setup_result)
self.assertFalse(setup_result)
mock_connect.assert_called_once_with(
'review.openstack.org', port=rcs.DEFAULT_PORT, key_filename='key',
username='user')