x/vmware-nsx
Code Issues Proposed changes

Skip updating logical port when removing router interface

Browse Source 
During the process of removing a router interface,
the plugin sends three API requests to the backend:
(1) DELETE logical router port,
(2) PUT logical port,
(3) DELETE logical port.

The PUT request is used to remove security group bindings and
change admin state to DOWN on the corresponding logical port.

Since a DELETE request will be sent right after the PUT request,
the PUT request can be skipped if the backend will auto-remove
security group bindings during a DELETE operation.

Change-Id: I73f563a71562a54f75a94e575d4f5248d973e78f
This commit is contained in:
Shih-Hao Li 2015-12-08 11:18:47 -08:00
parent 4924166aad
commit a9d479ab61
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
vmware_nsx/plugins/nsx_v3/plugin.py
View File

@ -691,13 +691,6 @@ class NsxV3Plugin(addr_pair_db.AllowedAddressPairsMixin,
if not self._network_is_external(context, port['network_id']):
_net_id, nsx_port_id = nsx_db.get_nsx_switch_and_port_id(
context.session, port_id)
# Update port to remove security group bindings from the
# backend and change it's admin state to DOWN
updated_port = {'port': {ext_sg.SECURITYGROUPS: [],
'admin_state_up': False}}
self._update_port_on_backend(context, nsx_port_id,
port, updated_port,
[], [])
self._port_client.delete(nsx_port_id)
self.disassociate_floatingips(context, port_id)
ret_val = super(NsxV3Plugin, self).delete_port(context, port_id)